[UR][Offload] Implement (most) kernel info queries #19806
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all of the required kernel info queries have been implemented. The only exception is `NUM_ARGS`, which isn't reported by liboffload, CUDA or HSA (the UR plugins return the *current* number of arguments, not the total). This test has been marked as a known failure and tests that use it as a placeholder value have been changed to use NAME.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
reviewed
Aug 21, 2025
| case UR_KERNEL_INFO_ATTRIBUTES: | ||
| return ReturnValue(""); | ||
| case UR_KERNEL_INFO_NUM_ARGS: | ||
| // This is unimplementable on liboffload (and AMD/Nvidia in general) |
There was a problem hiding this comment.
This is implementable in the adapter, hKernel->Args->Storage.size() (or something to that effect)
There was a problem hiding this comment.
Sorry I just read the PR description. I think if we're being more strict with the meaning then CUDA and HIP should be marked unsupported as well.
There was a problem hiding this comment.
And actually if what the CUDA and HIP adapters do is good enough for SYCL just now then maybe we can relax the UR spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of the required kernel info queries have been implemented.
The only exception is
NUM_ARGS, which isn't reported by liboffload,CUDA or HSA (the UR plugins return the current number of arguments,
not the total). This test has been marked as a known failure and tests
that use it as a placeholder value have been changed to use NAME.